[chef-dev] gem_package (and shellout generally) on windows


Chronological Thread 
  • From: Joseph Holsten < >
  • To: Chef Dev < >
  • Subject: [chef-dev] gem_package (and shellout generally) on windows
  • Date: Thu, 1 Nov 2012 20:15:54 -0700

This was fun: http://tickets.opscode.com/browse/CHEF-3579

Essentially, gem_package is trying to shellout!() to gem deep in C:\Program 
Files.  But shellout isn't quoting or escaping (correctly?). I just tried 
looking at mixlib-shellout/lib/mixlib/shellout/windows.rb, but clearly I'm 
out of my depth trying to grok win32/process.

https://github.com/opscode/chef/blob/master/lib/chef/provider/package/rubygems.rb#L505

Should that command be quoted before it gets to shellout? Should whitespace 
be escaped instead? Should shellout handle it transparently?
--
http://josephholsten.com


Archive powered by MHonArc 2.6.16.

§