[chef-dev] Re: Re: file deploy resource

[Andrea Campi < >]

On Mon, Feb 25, 2013 at 6:38 PM, Jesse Campbell < " target="_blank"> > wrote:

and here, solving CHEF-2506 and COOK-2444, I moved the etag and last-modified header checks to the base remote_file provider

https://github.com/jcam/chef/compare/rest_client_11...jcam:remote_file_deploy

I'll put together a bug and pull request once i write some unit tests

Looks good overall, however it also increases complexity and I'm not sure that's warranted.

In particular, for HTTP do you really need to send a HEAD request first?

You should send the IMS / INM headers on the GET request. 

COOK-2444 has a link to a branch that appears to do so, you may want to look at that.

That may even allow you to do away with grab_fileinfo_from_uri--that's up to you.

Also, it looks like some of the "wishlist" items in CHEF-2506 are still not addressed--namely handling of Expires and Cache-Control.

Personally I would not consider these a blocker and would send the pull request anyway; but I would leave the issue open (or split these into a new issue).

try_multiple_sources doesn't look like it's really iterating over sources?

Thanks for tackling this!