[chef-dev] 7/25 Opscode Code Review

[Bryan McLellan < >]

Catching up on knife plugins continues.

Merge:
  KNIFE-332 - knife-eucalyptus - Properly handle bogus "replay attack" 
failures

Other:
  KNIFE-93 - knife-ec2 - Knife.rb should support an option for 
knife[:identity_file]
  Reviewed - We need to determine if this is still reproducible
  KNIFE-103 - knife-ec2 - Knife.rb should support an option for 
knife[:ssh_user] as well as knife[:security_groups] node_name, and the 
run_list
  Reviewed - We need to determine if this is still reproducible
  KNIFE-333 - knife-ec2 - knife ec2 server list should include information 
relevant to VPC users
  Wontfix - We don't want to duplicate the ec2-describe-instances tool
  KNIFE-9 - knife-windows - Unable to compile native ruby gems on windows 
using embedded ruby in MSI package
  Reopened - Should this be in the MSI?
  KNIFE-18 - knife-windows - Knife-windows Plugin Bootstrap Blowing Up 
Finding "()" in System Path
  Wontfix - the windows-shell template is deprecated in favor of the 
windows-chef-client-msi template
  KNIFE-3018 - knife-windows - EC2 instances should use the EC2 instance_id 
as the default Chef node_name
  Wontfix - This should work fine now via knife ec2 server create
  KNIFE-2618 - knife-windows - knife[:winrm_attribute] from knife.rb / 
Chef::Config[:knife][:winrm_attribute] should be consulted similar to 
knife[:ssh_attribute]
  Reopened - Need to  clean this up, and verify if we need  a winrm_attribute 
or just use attribute

---
Bryan McLellan | opscode | technical program manager, open source
(c) 206.607.7108 | (t) @btmspox | (b) http://blog.loftninjas.org