Hi Cary,
I took a look at this again, and I think ssh_port should be left under cloud, and not specific to azure. I would like to patch 'knife ssh' to use ssh_port, much in the same way that it uses cloud.public_hostname now. (https://github.com/opscode/chef/blob/master/lib/chef/knife/ssh.rb#L157) This can't be azure specific for obvious reasons.
Azure can have multiple nodes behind a single virtual IP or hostname, and use different ports for ssh. I can imagine having customized ssh ports per-node could be desirable in other situations.
Thanks,
Jeff Mendoza
Date: Mon, 23 Dec 2013 15:51:42 -0800
From: " target="_blank">
To: " target="_blank">
Subject: [chef-dev] REVIEW: Ohai Cloud Plugin Improvements (OHAI-542)
Ohai!
Just submitted a PR to help make the ohai cloud plugin more consistent across clouds:
https://tickets.opscode.com/browse/OHAI-542
There are some breaking changes for GCE and Azure as documented.
Thoughts? Questions? Concerns?
Best regards,
Cary P
Archive powered by MHonArc 2.6.16.