[chef] Re: Fw: [[chef-dev]] Will attribute merge ordering fix for nested roles be merged in 0.10.0?


Chronological Thread 
  • From: Rob Guttman < >
  • To:
  • Cc: Daniel DeLeo < >
  • Subject: [chef] Re: Fw: [[chef-dev]] Will attribute merge ordering fix for nested roles be merged in 0.10.0?
  • Date: Thu, 17 Mar 2011 21:13:58 -0400
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; b=Q8KN55KJZvkHBIrWSwQsp3DuUDUwIoThUlFHzKa2grXPN6jXF2TLHE0rq9SHCgzTPo X2yxYNbf0vAxEJmYDmwr3OYEzjm9bbNgtp5qlM0Eg6y5McciT3MjN9FTjGNGMMte9g9A Aum5q6kApnGqn2ARdbu1a/1AFBlsoAes3k8qo=

7 should win.  I just ran into this problem this week.  I solved it by 'demoting' the base's attribute to default and keeping the appserver's attribute as override - but that was very much a workaround to achieve the desired (and expected) behavior.

- Rob


On Thu, Mar 17, 2011 at 9:04 PM, Daniel DeLeo < "> > wrote:
Forwarding this to the primary list so everyone can chime in. I don't have a strong opinion either way, but I would like to ensure there is strong support for changing the current behavior before going ahead with this.

To summarize the issue for those unfamiliar:

Given:
* A role "base"
* A role "appserver" that includes role "base"

When both roles set an attribute, which one should "win"? E.g., if both "base" and "appserver" define an attribute "logrotate_days", but you have:
* base: logrotate_days => 5
* appserver: logrotate_days => 7

What should be the value of logrotate days when a node has the "appserver" role? The current behavior is that "base" wins, so logrotate_days would be 5, because it is included last. The bug report asserts that the behavior should be the opposite.


Thanks,
-- 
Dan DeLeo

Forwarded message:


Some background:

The last link has a good summary of use case at the top.  Last update was that this was potentially a breaking change and so had to wait until 0.10.0 to be considered.  I'm wondering if there's been any discussion on including it.  I personally feel that the current behavior is very unintuitive and generally undesirable, but perhaps there are use cases I haven't considered. 

FWIW I've been running my chef clients with this patch from 0.9.8 through 0.9.14 without issue. 





Archive powered by MHonArc 2.6.16.

§