[chef] Re: FC001, attributes as strings vs symbols

[Joshua Timberman < >]

Ohai!

On Oct 30, 2012, at 1:36 AM, Alex Howells 
<
 >
 wrote:

> Any update or results?


Yes, in fact, there is both. The results are in, after two weeks of the 
survey being open:

https://www.evernote.com/shard/s5/sh/1fc5a0c9-bdd0-44f4-8f5a-ed2ddc9d2cfd/a13f36acd7cfa2a468f7829e5549209f

To summarize the chart: 50.6% prefer symbols, 33.9% prefer strings and 15.5% 
prefer methods (dot notation). In my opinion, there isn't enough of 
difference to make foodcritic have a rule detecting any of these.

The update is, that along with discussion at the summit with several people, 
including Andrew Crump, the consensus is rule FC001 is low value because the 
difference isn't definitive. I created an issue and pull request removing 
FC001 from foodcritic.

* https://github.com/acrmp/foodcritic/issues/86
* https://github.com/acrmp/foodcritic/pull/87

This is merged. Thanks Andrew for that, and I'm sorry I missed the additional 
features.

The rule that *does* have value for a lint check is FC019, which states, 
"Access node attributes in a consistent manner."

-- 
Opscode, Inc
Joshua Timberman, Technical Community Manager
IRC, Skype, Twitter, Github: jtimberman