Re: More problems with remote_file

[Adam Jacob <adam@opscode.com>]

It was deliberate - I added a guard to ensure that, no matter how we
get the filehandle, it's only closed if it's open.

Adam

On Tue, Jun 9, 2009 at 11:55 PM, Jeppe Nejsum Madsen<jeppe@ingolfs.dk> wrote:
> Seems to work. At least unable to reproduce with the steps below. Nice!
>
> Was this a deliberate fix or just fixed by coincidence?
>
> /Jeppe
>
> On 10/06/2009, at 04.09, Adam Jacob wrote:
>
>> Jeppe, can you try this with 0.7.0?
>>
>> Sent from my iPhone
>>
>> On Jun 9, 2009, at 6:11 AM, Jeppe Nejsum Madsen <jeppe@ingolfs.dk> wrote:
>>
>>> On Tue, Jun 9, 2009 at 11:58 AM, Jeppe Nejsum Madsen<jeppe@ingolfs.dk>
>>> wrote:
>>>>
>>>> On Mon, Jun 8, 2009 at 7:16 PM, Jeppe Nejsum Madsen<jeppe@ingolfs.dk>
>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I seem to occasionally get some errors with remote_file when running
>>>>> chef-solo. It is not consistently reproducible, but seems to occur when
>>>>> I
>>>>> rerun a chef-solo command and the target file already exists.
>>>>
>>>> Hmm seems to be a platform thing. On an EC2 instance running Ubuntu
>>>> 8.04, I cannot reproduce this. On an EC2 instance running 9.04 I can
>>>> consistently reproduce this....
>>>>
>>>> /Jeppe
>>>>
>>>
>>> And just to keep the dialogue with myself:  I'm pretty sure it's
>>> caused by Ruby 1.8.7 which is default on Ubuntu 9.04. Downgrading to
>>> 1.8.6 solves the problem.
>>>
>>> The strange part is that it only happens on some files. I've created a
>>> very small test scenario which consistently fails on 9.04 after the
>>> first successful run. After downgrading to Ruby 1.8.6, I can run this
>>> scenario several times without failure:
>>>
>>> 1) Create solo.rb
>>> cookbook_path    "/etc/chef/recipes/cookbooks"
>>> log_level        :debug
>>> file_store_path  "/var/chef/files/"
>>> file_cache_path  "/etc/chef/recipes"
>>>
>>> 2) gem install --no-ri --no-rdoc --bindir /sbin ohai chef --source
>>> http://gems.opscode.com --source http://gems.rubyforge.org
>>> 3) chef-solo -c solo.rb -j http://jnmtest.s3.amazonaws.com/dna.json -l
>>> debug -r http://jnmtest.s3.amazonaws.com/cookbooks.tgz
>>> 4) chef-solo -c solo.rb -j http://jnmtest.s3.amazonaws.com/dna.json -l
>>> debug -r http://jnmtest.s3.amazonaws.com/cookbooks.tgz
>>>
>>> The last step always fails for the last file when running on 9.04 with
>>> Ruby 1.8.7 but works with Ruby 1.8.6
>>>
>>> /Jeppe
>
>



-- 
Opscode, Inc.
Adam Jacob, CTO
T: (206) 508-4759 E: adam@opscode.com