[chef] Re: COOK-3084 - wrong python on RHEL5


Chronological Thread 
  • From: Steven Danna < >
  • To: < >
  • Subject: [chef] Re: COOK-3084 - wrong python on RHEL5
  • Date: Thu, 6 Jun 2013 06:26:53 -0700

On 6/5/13 1:50 PM, Alex Kiernan wrote:

> diff --git a/providers/virtualenv.rb b/providers/virtualenv.rb
> index dfd9f4e..addb724 100644
> --- a/providers/virtualenv.rb
> +++ b/providers/virtualenv.rb
> @@ -29,7 +29,8 @@ end
>  action :create do
>    unless exists?
>      Chef::Log.info("Creating virtualenv #{new_resource} at
> #{new_resource.path}")
> -    execute "#{virtualenv_cmd} --python=#{new_resource.interpreter}
> #{new_resource.options} #{new_resource.path}" do
> +    interpreter = new_resource.interpreter ? "
> --python=#{new_resource.interpreter}" : ""
> +    execute "#{virtualenv_cmd}#{interpreter} #{new_resource.options}
> #{new_resource.path}" do
>        user new_resource.owner if new_resource.owner
>        group new_resource.group if new_resource.group
>      end

As I mentioned in the code review, I would be +1 on this as an
intermediary step before the full fix.


-- 
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key

Attachment: signature.asc
Description: OpenPGP digital signature




Archive powered by MHonArc 2.6.16.

§