Tests completed across all platforms on the avoid-venv-python branch successfully. Should I update the ticket back to fix provided and point at this branch?
Four branches pushed:- simple tests for this issue: https://github.com/akiernan/python/tree/add-venv-tests- patch level change: https://github.com/akiernan/python/tree/handle-rhel5- minor level change:https://github.com/akiernan/python/tree/avoid-venv-python- major level change: https://github.com/akiernan/python/tree/remove-interpreterAll three changes pass for CentOS 5.9/6.4 package installs; I'm leaving the minor level change (the proposed patch earlier in this thread) running the full suite and will update the ticket assuming it passes.On Thu, Jun 6, 2013 at 5:42 PM, Alex Kiernan < " target="_blank"> > wrote:
A big +1 from me for the -1 on the ticket... you've made me go and get test-kitchen working :)
I've added a test-kitchen test cookbook to show the problem and I'm just testing out the three branches which do what I think are the options:- patch level, fix up what's passed to --python (my original patch)- minor level, don't pass in --python unless interpreter is explicitly specified- major level, drop interpreter altogetherMay or may not get to it this evening, depends how soon my wife makes it home (I gather the traffic's terrible, so I may get it done :))--On Thu, Jun 6, 2013 at 2:59 PM, Steven Danna < " target="_blank"> > wrote:
On 6/6/13 6:49 AM, Mike wrote:For most cases it will work as expected. I believe that certain methods
> Q: Can you use node attributes in providers? When do they resolve, and
> if a subsequent attribute is set later in the run, how does that
> affect this?
>
> If the answer is "it's all good and cool - setting
> node['python']['binary'] in a role/env/override attribute later works
> as expected", then I think I'm on board with the change.
of updating attributes inside a recipe could cause problems, but I would
have have to do some experimentation to be sure.
Overall, however, I don't like using node attributes to modify resource
behavior behind the scenes like this as it puts the data which modifies
the behavior of a resource pretty far from the resource itself.
Cheers,
Steven
--
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key
Alex Kiernan--
Alex Kiernan
Archive powered by MHonArc 2.6.16.