[chef] Re: Output formatter doc lacks information about handlers

[Steffen Gebert < >]

Thanks for your quick reply, Daniel!

Do you agree with the format I've posted?

I'm unfortunately not able to get rid of the empty line before the
"completed" line.

As these handlers are "actively" executed: should they be colored in green?

Yours
Steffen

On 25/11/13 19:41, Daniel DeLeo wrote:
> 
> 
> On Monday, November 25, 2013 at 10:31 AM, Steffen Gebert wrote:
> 
>> Hi Daniel,
>>  
>>>>> A patch for this would be welcome.
>>  
>> I just noticed that the difference is the log level :-/
>>  
>> When I run `chef-client -l info`, I get some output, of course.
>>  
>> Should I still add that to the `doc` formatter?
>>  
>> The output would be then
>>> Running handlers:
>>> [2013-11-25T19:26:42+01:00] INFO: Running report handlers
>>> - LastRunUpdateHandler finished
>>> - Etckeeper::CommitHandler finished
>>> [2013-11-25T19:26:43+01:00] INFO: Zabbix::Report handler started
>>> - Zabbix::Report finished
>>>  
>>> Running handlers completed
>>>  
>>> [2013-11-25T19:26:43+01:00] INFO: Report handlers complete
>>  
>> (where the "Zabbix::Report handler started" part comes from the handler
>> itself).
>>  
>> With `-l warn` it looks like this:
>>  
>>> Running handlers:
>>> - LastRunUpdateHandler finished
>>> - Etckeeper::CommitHandler finished
>>> - Zabbix::Report finished
>>>  
>>> Running handlers completed
>>  
>> Code is here:
>>  
>> https://github.com/StephenKing/chef/commits/CHEF-4784
>>  
>> Yours
>> Steffen
>>  
>>  
> 
> Yes, the general idea is that whenever a human is running chef-client, the 
> formatter output should be used, while the logger output is still used when 
> logging to a file or central aggregator for post-hoc analysis. The “doc” 
> formatter is intended to be the sorta-verbose default that uses color and 
> structure to make information more scannable, so if there’s a crucial piece 
> of information missing, then it should be included.
> 
> 
> --  
> Daniel DeLeo
> 
>